Skip to content

[GPII-4195] Add 1909 and LTSC Windows 10 version to Vagrantfile#314

Open
amatas wants to merge 5 commits into
GPII:masterfrom
amatas:GPII-4195
Open

[GPII-4195] Add 1909 and LTSC Windows 10 version to Vagrantfile#314
amatas wants to merge 5 commits into
GPII:masterfrom
amatas:GPII-4195

Conversation

@amatas

@amatas amatas commented Apr 23, 2020

Copy link
Copy Markdown

https://issues.gpii.net/browse/GPII-4195

This PR depends on GPII/ci-service#75. Both should be merged at the same time, otherwise the CI will fail.

@gpii-bot

Copy link
Copy Markdown

CI job failed: https://ci.gpii.net/job/windows-tests/1342/

@amatas

amatas commented Apr 24, 2020

Copy link
Copy Markdown
Author

ok to test
in order to force the download of the vagrant boxes.

The tests run but the output is mixed due to the tests in both VMs are executed at the same time, before the GPII/ci-service#75 is merged.

@gpii-bot

Copy link
Copy Markdown

CI job failed: https://ci.gpii.net/job/windows-tests/1346/

@amb26

amb26 commented Apr 24, 2020

Copy link
Copy Markdown
Member

Failure during first CI task:

+ vagrant winrm -c 'do.ps1 -c '\''grunt lint'\'''
This command requires a specific VM name to target in a multi-VM environment.
Build step 'Execute shell' marked build as failure

@amatas

amatas commented Apr 24, 2020

Copy link
Copy Markdown
Author

Failure during first CI task:

+ vagrant winrm -c 'do.ps1 -c '\''grunt lint'\'''
This command requires a specific VM name to target in a multi-VM environment.
Build step 'Execute shell' marked build as failure

This is expected, the VM name is specified in GPII/ci-service#75

@javihernandez

Copy link
Copy Markdown
Member

LGTM

So we only need to provide a backwards compatible patch for the language test case.

@javihernandez

Copy link
Copy Markdown
Member

So we only need to provide a backwards compatible patch for the language test case.

Created PR against @amatas branch with the required changes, see amatas#1

GPII-4195: Updated languageTests to support testing on LTSC and postLTSC
@gpii-bot

Copy link
Copy Markdown

CI job failed: https://ci.gpii.net/job/windows-tests/1358/

@gpii-bot

gpii-bot commented May 6, 2020

Copy link
Copy Markdown

CI job failed: https://ci.gpii.net/job/windows-tests/1376/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants