Skip to content

GPII-2843: Fix the broken browser channel example#586

Open
cindyli wants to merge 8 commits into
GPII:masterfrom
cindyli:GPII-2843
Open

GPII-2843: Fix the broken browser channel example#586
cindyli wants to merge 8 commits into
GPII:masterfrom
cindyli:GPII-2843

Conversation

@cindyli

@cindyli cindyli commented Feb 2, 2018

Copy link
Copy Markdown
Contributor

Use the GPII config that includes the local flow manager to support the browser channel example.

@gpii-bot

gpii-bot commented Feb 2, 2018

Copy link
Copy Markdown

CI job passed: https://ci.gpii.net/job/universal-tests/685/

@cindyli cindyli requested a review from amb26 February 2, 2018 15:39
Comment thread documentation/BrowserChannel.md Outdated
start the GPII in the CloudBased browserChannel test configuration from the root of universal with

node gpii.js gpii/configs gpii.config.cloudBased.production
node gpii.js gpii/configs gpii.config.development.all.local

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it will be more helpful to direct the user to one of our mock configurations like https://github.com/GPII/universal/blob/master/gpii/configs/mocks/gpii.config.development.all.local.mock.windows.json5 which will allow them to see the results of a wider range of preference sets

@cindyli

cindyli commented Feb 2, 2018

Copy link
Copy Markdown
Contributor Author

I've made the change. Ready for another look, @amb26.

@gpii-bot

gpii-bot commented Feb 2, 2018

Copy link
Copy Markdown

CI job passed: https://ci.gpii.net/job/universal-tests/686/

@cindyli

cindyli commented Mar 1, 2018

Copy link
Copy Markdown
Contributor Author

@amb26, now the initial user settings are set and returned at connectionSucceeded. The changes include:

  1. This example cannot use mock windows config file because the mock setImpl() does not set payload to the proper model path at model.settings;
  2. Using gpii.config.development.all.local config reads solution registry from darwin.json, which requires to add net.gpii.uioPlus solution into this JSON file.

This pull request is ready to be reviewed.

@gpii-bot

gpii-bot commented Mar 1, 2018

Copy link
Copy Markdown

CI job failed: https://ci.gpii.net/job/universal-tests/727/

@cindyli

cindyli commented Mar 1, 2018

Copy link
Copy Markdown
Contributor Author

ok to test

@gpii-bot

gpii-bot commented Mar 1, 2018

Copy link
Copy Markdown

CI job failed: https://ci.gpii.net/job/universal-tests/728/

…ocker container to find out if it helps to work around the couchdb connection failure.
@gpii-bot

gpii-bot commented Mar 1, 2018

Copy link
Copy Markdown

CI job passed: https://ci.gpii.net/job/universal-tests/729/

@gpii-bot

gpii-bot commented Mar 1, 2018

Copy link
Copy Markdown

CI job passed: https://ci.gpii.net/job/universal-tests/732/

@gtirloni

gtirloni commented Jun 1, 2018

Copy link
Copy Markdown
Contributor

ok to test

@gpii-bot

gpii-bot commented Jun 1, 2018

Copy link
Copy Markdown

CI job failed: https://ci.gpii.net/job/universal-tests/884/

@gpii-bot

gpii-bot commented Jun 1, 2018

Copy link
Copy Markdown

CI job passed: https://ci.gpii.net/job/universal-tests/886/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants