IActionContextAccessor being deprecated

[nickalbrecht]

An announcement from a few weeks ago mentioned that IActionContextAccessor and ActionContextAccessor are being deprecated (starting with .NET 10), which SubresourceIntegrityTagHelper and its child classes make use of (as do a few other classes).

The recommended alternative looks like this, and only requires injecting IHttpContextAccessor

var httpContext = httpContextAccessor.HttpContext;
var endpoint = httpContext?.GetEndpoint();
var actionDescriptor = endpoint?.Metadata.GetMetadata<ActionDescriptor>();

[nickalbrecht]

In the case of SubresourceIntegrityTagHelper, it looks like it's only used to call urlHelper.Content() , which can probably be simplified to something like this.

private string GetSubresourceIntegrityFromContentFile(
    string contentPath,
    SubresourceIntegrityHashAlgorithm hashAlgorithms)
{
    var filePath = Path.Combine(
        webHostEnvironment.WebRootPath,
        contentPath.TrimStart('~', '/') ?? string.Empty);
    var bytes = ReadAllBytes(filePath);
    return GetSpaceDelimetedSri(bytes, hashAlgorithms);
}

Though that yields some ugly paths due to mismatched directory separators (at least for me due to being on windows) because of the WebRootPath using \\ and the contentPath using /. Even though File.ReadAllBytes() doesn't seem to care and reads the file just fine. Either way I think something like this results in better paths.

private string GetSubresourceIntegrityFromContentFile(
    string contentPath,
    SubresourceIntegrityHashAlgorithm hashAlgorithms)
{
    var filePath = Path.Combine(
        webHostEnvironment.WebRootPath,
        contentPath.TrimStart('~', '/').Replace('/', Path.DirectorySeparatorChar) ?? string.Empty);
    var bytes = ReadAllBytes(filePath);
    return GetSpaceDelimetedSri(bytes, hashAlgorithms);
}

Doing that means you no longer need IActionContextAccessor or IUrlHelperFactory at all.