Skip to content

Make translator.save_xml relative to script not output_folder #121

Description

@nllong

When calling

translator.save_xml(File.join(save_file_name))

the results are stored relative to where you defined the output_folder as defined in the object instantiation.

translator = BuildingSync::Translator.new(xml_file, output_folder, epw_file_path)

If passing in a nonabsolute path, then IMO it should be relative to where you ran the script, not relative to the location of the object instantiation.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions