From 4e6f2f9bc186ad5f141802027418fd4774433b8e Mon Sep 17 00:00:00 2001 From: Juan Miguel Carceller Date: Wed, 17 Jun 2026 11:05:00 +0200 Subject: [PATCH] Remove the method isValid for Collections --- include/podio/CollectionBase.h | 2 -- include/podio/UserDataCollection.h | 6 ------ include/podio/detail/LinkCollectionImpl.h | 6 ------ python/templates/Collection.h.jinja2 | 6 ------ 4 files changed, 20 deletions(-) diff --git a/include/podio/CollectionBase.h b/include/podio/CollectionBase.h index 1f3982f12..63a1a57d4 100644 --- a/include/podio/CollectionBase.h +++ b/include/podio/CollectionBase.h @@ -48,8 +48,6 @@ class CollectionBase { virtual bool hasID() const = 0; - virtual bool isValid() const = 0; - /// number of elements in the collection virtual size_t size() const = 0; diff --git a/include/podio/UserDataCollection.h b/include/podio/UserDataCollection.h index 361bb0034..d10e42b3f 100644 --- a/include/podio/UserDataCollection.h +++ b/include/podio/UserDataCollection.h @@ -157,12 +157,6 @@ class UserDataCollection : public CollectionBase { getID() != static_cast(podio::ObjectID::invalid); } - [[deprecated("isValid will be removed, use hasID() if you want to check if it has an ID, otherwise assume the " - "collection is valid")]] - bool isValid() const override { - return hasID(); - } - /// number of elements in the collection size_t size() const override { return _vec.size(); diff --git a/include/podio/detail/LinkCollectionImpl.h b/include/podio/detail/LinkCollectionImpl.h index cf498c31d..1566fb2d0 100644 --- a/include/podio/detail/LinkCollectionImpl.h +++ b/include/podio/detail/LinkCollectionImpl.h @@ -261,12 +261,6 @@ class LinkCollection : public podio::CollectionBase { getID() != static_cast(podio::ObjectID::invalid); } - [[deprecated("isValid will be removed, use hasID() if you want to check if it has an ID, otherwise assume the " - "collection is valid")]] - bool isValid() const override { - return hasID(); - } - podio::CollectionWriteBuffers getBuffers() override { return m_storage.getCollectionBuffers(m_isSubsetColl); } diff --git a/python/templates/Collection.h.jinja2 b/python/templates/Collection.h.jinja2 index c74a50d5c..a30d164f7 100644 --- a/python/templates/Collection.h.jinja2 +++ b/python/templates/Collection.h.jinja2 @@ -161,12 +161,6 @@ public: getID() != static_cast(podio::ObjectID::invalid); } - [[deprecated("isValid will be removed, use hasID() if you want to check if it has an ID, otherwise assume the " - "collection is valid")]] - bool isValid() const final { - return hasID(); - } - size_t getDatamodelRegistryIndex() const final; // support for the iterator protocol